Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add KCLRun spec #7

Merged
merged 1 commit into from
Feb 1, 2024
Merged

feat: add KCLRun spec #7

merged 1 commit into from
Feb 1, 2024

Conversation

zong-zhe
Copy link
Collaborator

@zong-zhe zong-zhe commented Feb 1, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the enhancement New feature or request label Feb 1, 2024
@zong-zhe zong-zhe requested review from i-zhen and Peefy February 1, 2024 07:15
@zong-zhe zong-zhe self-assigned this Feb 1, 2024
domain: kcl-lang.io
group: krm.kcl.dev.fluxcd
kind: KCLRun
path: github.com/kcl-lang/kcl-controller/api/v1alpha1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/kcl-controller/flux-kcl-controller

Modifications need to be completed throughout the entire go warehouse.

@Peefy Peefy merged commit 1f05c51 into kcl-lang:main Feb 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants