Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotless code formatting #124

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Spotless code formatting #124

wants to merge 1 commit into from

Conversation

kbuntrock
Copy link
Owner

No description provided.

@kbuntrock kbuntrock marked this pull request as draft March 4, 2024 22:40
@murdos
Copy link
Contributor

murdos commented Sep 1, 2024

Hi! Do you plan to finish this setup?
It would really ease contributing: if you don't have to pay attention to formatting since it could be done with just one maven run :)

@kbuntrock
Copy link
Owner Author

kbuntrock commented Sep 6, 2024

Hi! Do you plan to finish this setup? It would really ease contributing: if you don't have to pay attention to formatting since it could be done with just one maven run :)

Yes, I really should. Initially I stopped because I did not want to complexify the review / merge of this PR which was beeing developed at the time : #120

But since it has not evolved since a long time (and theses features are not a personal priority), I can finish to implement the automatic code formatting.

I also remember that I was not so pleased with the hard coded line length of the palantir format. Too short for my taste. But it's better than nothing.

Do you have any recommendations in term of formatters?

@murdos
Copy link
Contributor

murdos commented Sep 8, 2024

Initially I stopped because I did not want to complexify the review / merge of this PR which was beeing developed at the time : #120

This feature is clearly a must-have for my use-cases.

But since it has not evolved since a long time (and theses features are not a personal priority), I can finish to implement the automatic code formatting.

I see that there's just one sub-task that is not done. Maybe it can merged, event if the support is not at 100%, if the design is OK?

I also remember that I was not so pleased with the hard coded line length of the palantir format. Too short for my taste. But it's better than nothing.
Do you have any recommendations in term of formatters?

I use prettier formatting for all my projects, but it's opinionated, and might not fit to all tastes :)
Here's an example of configuration with spotless: https://github.com/murdos/easy-random-protobuf/blob/589542fee90ad7cb2bc49643fe31b62c487326a1/pom.xml#L177-L186

@kbuntrock
Copy link
Owner Author

Initially I stopped because I did not want to complexify the review / merge of this PR which was beeing developed at the time : #120

This feature is clearly a must-have for my use-cases.

But since it has not evolved since a long time (and theses features are not a personal priority), I can finish to implement the automatic code formatting.

I see that there's just one sub-task that is not done. Maybe it can merged, event if the support is not at 100%, if the design is OK?

I also remember that I was not so pleased with the hard coded line length of the palantir format. Too short for my taste. But it's better than nothing.
Do you have any recommendations in term of formatters?

I use prettier formatting for all my projects, but it's opinionated, and might not fit to all tastes :) Here's an example of configuration with spotless: https://github.com/murdos/easy-random-protobuf/blob/589542fee90ad7cb2bc49643fe31b62c487326a1/pom.xml#L177-L186

Thank you for the example, I'll have a look at the result of a "prettier" formatting at my return.

Concerning the PR #120, I have not read the code back in the days I spotted the work on it. Same, I add it to my to-do post holidays. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants