-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spotless code formatting #124
base: dev
Are you sure you want to change the base?
Conversation
Hi! Do you plan to finish this setup? |
Yes, I really should. Initially I stopped because I did not want to complexify the review / merge of this PR which was beeing developed at the time : #120 But since it has not evolved since a long time (and theses features are not a personal priority), I can finish to implement the automatic code formatting. I also remember that I was not so pleased with the hard coded line length of the palantir format. Too short for my taste. But it's better than nothing. Do you have any recommendations in term of formatters? |
This feature is clearly a must-have for my use-cases.
I see that there's just one sub-task that is not done. Maybe it can merged, event if the support is not at 100%, if the design is OK?
I use prettier formatting for all my projects, but it's opinionated, and might not fit to all tastes :) |
Thank you for the example, I'll have a look at the result of a "prettier" formatting at my return. Concerning the PR #120, I have not read the code back in the days I spotted the work on it. Same, I add it to my to-do post holidays. :) |
No description provided.