fix edge case with filename creation and duplicate tags

kbravh · Jul 16, 2022 · 9d10a74 · 9d10a74
1 parent 5104479
commit 9d10a74
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/src/util.ts b/src/util.ts
@@ -212,10 +212,13 @@ export const createFilename = (
 ): string => {
   filename = filename ? filename : '[[handle]] - [[id]]'
   filename = filename.replace(/\.md$/, '') // remove md extension if provided
-  filename = filename.replace('[[name]]', tweet.includes.users[0].name)
-  filename = filename.replace('[[handle]]', tweet.includes.users[0].username)
-  filename = filename.replace('[[id]]', tweet.data.id)
-  filename = filename.replace('[[text]]', tweet.data.text)
+  filename = filename.replace(/\[\[name\]\]/gi, tweet.includes.users[0].name)
+  filename = filename.replace(
+    /\[\[handle\]\]/gi,
+    tweet.includes.users[0].username
+  )
+  filename = filename.replace(/\[\[id\]\]/gi, tweet.data.id)
+  filename = filename.replace(/\[\[text\]\]/gi, tweet.data.text)
   // date
   const dateRegex = /\[\[(date[:\w-]*)\]\]/
   if (dateRegex.test(filename)) {

diff --git a/tests/util.test.ts b/tests/util.test.ts
@@ -111,6 +111,14 @@ describe('Create filename', () => {
       })
     ).toBe('Mappletons - 1292845757297557505 - Maggie Appleton 🧭.md')
   })
+  it('Replaces multiple occurrences of placeholders', () => {
+    expect(
+      createFilename(ImageTweet, '[[id]] - [[id]]', {
+        locale: 'en',
+        format: 'YYYY-MM-DD',
+      })
+    ).toBe('1292845757297557505 - 1292845757297557505.md')
+  })
   it('Replaces text and truncates', () => {
     expect(
       createFilename(ImageTweet, '[[text]]', {