This repository has been archived by the owner on Feb 25, 2020. It is now read-only.
Unclear message on incorrect credentials #280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0608jennylee
suggested changes
Apr 8, 2019
Merged
0608jennylee
previously requested changes
Apr 8, 2019
There was a problem hiding this comment.
The submodules, Pong-Game, VisualGit_SE701_2019_3, and dummy, should be removed from this pull request.
The image pexels-photo-414612 does not seem to used, this should be removed.
theres some changes that dont seem to do anything, could you fix this, thanks.
0608jennylee
dismissed
their stale review
outdated comments - resolved by latest commit
0608jennylee
suggested changes
Apr 11, 2019
|
@iamkunalb is this working on your system, for some reason when I test it I just get a bunch of errors and nothing loads also the transcript compiler is getting some compiler issues from the file you have made modifications to, I'm not sure if this is causing the page to not load |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed unclear pop up message on incorrect credentials
Test:
or