Skip to content
This repository has been archived by the owner on Feb 25, 2020. It is now read-only.

[IMPROVEMENT] Improve the npm start script #321

Open
AbhinavBehal opened this issue Apr 12, 2019 · 3 comments
Open

[IMPROVEMENT] Improve the npm start script #321

AbhinavBehal opened this issue Apr 12, 2019 · 3 comments
Labels
Approved enhancement New feature or request Small

Comments

@AbhinavBehal
Copy link
Collaborator

Description
The current npm start script executes the createjs and electron:serve commands in parallel. While this is fine once the .js files have been generated, new clones of the repository will not work correctly and might throw an error. As documented in #302, the npm start script should be changed to first generate the .js files, and then run the createjs and electron:serve commands.

Acceptance criteria

  • As described above, the npm start should be changed to ensure that the generated .js files have been created before electron:serve is run.

Pointers / Solutions

  • Could potentially move the required functionality into an external script.

Additional context
#302

Related issues
#269

@rmberriman
Copy link
Collaborator

Approved!

@lukethompsxn
Copy link
Collaborator

Approved, I have experienced the problems this causes when testing #302

@AbhinavBehal AbhinavBehal changed the title [FEATURE] Improve the npm start script [IMPROVEMENT] Improve the npm start script Apr 12, 2019
@Z-Qi
Copy link
Collaborator

Z-Qi commented Apr 12, 2019

Approved as this should be the correct fix for the issues described in #302

@Z-Qi Z-Qi added the Approved label Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Approved enhancement New feature or request Small
Projects
None yet
Development

No branches or pull requests

4 participants