Skip to content
This repository has been archived by the owner on Feb 25, 2020. It is now read-only.

[IMPROVEMENT] Correctly use credentials.js for clearing saved credentials #322

Open
Z-Qi opened this issue Apr 12, 2019 · 3 comments
Open

[IMPROVEMENT] Correctly use credentials.js for clearing saved credentials #322

Z-Qi opened this issue Apr 12, 2019 · 3 comments
Labels
Approved enhancement New feature or request very small

Comments

@Z-Qi
Copy link
Collaborator

Z-Qi commented Apr 12, 2019

Description
Described in #302 and also by comments in the committed code. The functionality of clearing credentials should be moved to credentials.js for consistency.

Acceptance criteria
The keytar package is removed from index.js, and .../misc/credentials.js is to be used instead.

Pointers / Solutions
N/A

Additional context
#302, blocked by #321

Related issues
#321, #269
@Z-Qi Z-Qi added enhancement New feature or request very small labels Apr 12, 2019
@lukethompsxn
Copy link
Collaborator

Approved, this was discussed in conversion in #302

@SamuelZheng11
Copy link
Collaborator

Approved

@joel-clarke
Copy link
Collaborator

Approved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Approved enhancement New feature or request very small
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@SamuelZheng11 @rmberriman @Z-Qi @lukethompsxn @joel-clarke