Skip to content
This repository has been archived by the owner on Feb 25, 2020. It is now read-only.

[BUG] Unexpected redirect to login page #188

Open
Z-Qi opened this issue Mar 31, 2019 · 3 comments
Open

[BUG] Unexpected redirect to login page #188

Z-Qi opened this issue Mar 31, 2019 · 3 comments
Labels
bug Something isn't working Medium

Comments

@Z-Qi
Copy link
Collaborator

Z-Qi commented Mar 31, 2019

Describe the bug
When logging out, if a warning is shown due to uncommitted/unpushed code the warning for exiting the application also pops up.

To reproduce
Steps to reproduce the behavior:

  1. Open a repository
  2. If there are no changes, make one
  3. Attempt to log out
  4. There should be two popups, the 'log out' warning and under that the 'exit application' warning.

Expected behavior / Acceptance criteria
Should not be attempting to redirect to login page.

Screenshots
DHOWJSl7TZ

Desktop:

  • OS: Win10
@Z-Qi Z-Qi added bug Something isn't working Medium labels Mar 31, 2019
@hhagenson28
Copy link
Collaborator

Just tried to reproduce this bug (on Win10) and only got the second warning message, I did not see the 'log out' one at all.

@Z-Qi
Copy link
Collaborator Author

Z-Qi commented Mar 31, 2019

Sorry, forgot to mention this is related to the currently active pull request #186. Previous pull requests have 'broken' the old log out warning

@rmberriman
Copy link
Collaborator

Was unable to reproduce this bug on Windows 10, only got the second message not the 'Sign Out' one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Medium
Projects
None yet
Development

No branches or pull requests

3 participants