Skip to content
This repository has been archived by the owner on Feb 25, 2020. It is now read-only.

[BUG] Signout broken in local repository #272

Open
Z-Qi opened this issue Apr 8, 2019 · 3 comments
Open

[BUG] Signout broken in local repository #272

Z-Qi opened this issue Apr 8, 2019 · 3 comments
Assignees
Labels
Approved bug Something isn't working Medium

Comments

@Z-Qi
Copy link
Collaborator

Z-Qi commented Apr 8, 2019

Describe the bug
The current signout seems to have stopped working as intended due to a change in #173, the move from using confirmSignOut() has caused the signout warning to no longer show up. Instead when signout is clicked (where there are modified files) the exit application warning is shown also described in #188.

To reproduce
Steps to reproduce the behavior:

  1. Open a local repository with changes
  2. Click on signout
  3. Exit warning is shown instead of the intended signout warning

Expected behavior / Acceptance criteria
Functionality is returned to prior, signing out produces signout warnings where appropriate.

Screenshots
ajftG4VJ4Z

Desktop (please complete the following information):

  • OS: Win10, has also been tested on OSX

Related issues
#188

@Z-Qi Z-Qi added bug Something isn't working Medium labels Apr 8, 2019
@lukethompsxn
Copy link
Collaborator

Approved! I can reproduce this issue

@Jess-Alcantara
Copy link
Collaborator

Approved 👍

@hhagenson28
Copy link
Collaborator

I had also noticed this, approved!

@DionBalmforth DionBalmforth self-assigned this Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Approved bug Something isn't working Medium
Projects
None yet
Development

No branches or pull requests

5 participants