Added current password checker on the password reset page. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaclochhead
approved these changes
Mar 8, 2018
sidpartha1
approved these changes
Mar 8, 2018
umih874
added a commit
to umih874/QualOpt_SE701
that referenced
this pull request
Mar 22, 2018
umih874
added a commit
to umih874/QualOpt_SE701
that referenced
this pull request
Mar 22, 2018
Current password input box was set bunded to new password input box. So same error will display for both when new password box is invalid. Fixed it so that current password input box has its own error association.
umih874
pushed a commit
to umih874/QualOpt_SE701
that referenced
this pull request
Mar 28, 2018
Fixed the input box bounding error from Issue#27 (PR kblincoe#66) Current password input box was set bunded to new password input box. So same error will display for both when new password box is invalid. Fixed it so that current password input box has its own error association.
umih874
pushed a commit
to umih874/QualOpt_SE701
that referenced
this pull request
Mar 28, 2018
Fixed the input box bounding error from Issue#27 (PR kblincoe#66) Current password input box was set bunded to new password input box. So same error will display for both when new password box is invalid. Fixed it so that current password input box has its own error association. Added clear field functionality to password page Once the user applies changes the password input box will get cleared from the previously entered values. Redesigned main page. Added Login/Signup button and images. Added class to email body. Class preserves white space and new lines. add batch files to launch/test QualOpt added shell scripts for mac users updating formating of mac shell scripts Fix Twitter sign-in Issue kblincoe#8 Added a SendInvitation option to the main study page Connected GitHub API to search and instantiate new Participants Add warning that there are unsaved changes in the edit study form delete unnecessary whitespace (line 85) chore: add +x permission to mvnw kblincoe#57 Fixing typos Fixed all typing and punctuation errors in the abbout page kblincoe#29 Cleaning up about page Removed go to studies button and login status on the about page to make it look cleaner Added shadow to welcome text. Fixed Typo
umih874
pushed a commit
to umih874/QualOpt_SE701
that referenced
this pull request
Mar 28, 2018
(this is a squashed version) Delete Entities tab Fixed the input box bounding error from Issue#27 (PR kblincoe#66) Current password input box was set bunded to new password input box. So same error will display for both when new password box is invalid. Fixed it so that current password input box has its own error association.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE
Some further issues were discovered while working on the #120 issue. Namely, the error messages displayed for the current password input box where associated and caused by invalid input for the new password field. This bug was resolved and detailed changes can be seen in #128
Changes covered in this Pull Request
Current password checker has been added when the user tries to change their password. The user must now enter the current password to be able to change their password. The functionality and UI change is ready for review.
UI Changes
A new input box has been added to the form to change the user's password. This box is for entering the user's current password that will be checked before it can be reset.
Functional Changes
A changePassword method has been added to the password component and runs when the user tries to update their password. This method uses the login services login method to verify that the user has input the correct current password. The updated password will only be stored if the current password has been verified. Otherwise, an error message will appear.
Testing
UI Changes
Indicated in red rectangle
