Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build and upgrade to 5.2.0 #34

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Conversation

MrCreosote
Copy link
Member

Fixes #33
Fixes #32

Tested in CI dev, seems to work normally

@MrCreosote MrCreosote requested a review from Tianhao-Gu October 4, 2024 21:38
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how things worked without this file before, but it's imported by the server and post upgrade everything failed because it wasn't available. Copied from the installed_clients folder.

Regular kb_sdk's Docker version is so old tests won't pass on GHA
Copy link
Contributor

@Tianhao-Gu Tianhao-Gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MrCreosote MrCreosote merged commit dcb6361 into master Oct 7, 2024
1 check passed
@MrCreosote MrCreosote deleted the dev-fix_build_and_upgrade branch October 7, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quast no longer builds QUAST version is 5.0.2 but app title says it's 4.4
2 participants