Fix build, ignore google download tests #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrCreosote
requested review from
jsfillman,
jkbaumohl and
Tianhao-Gu
as code owners
Google download doesn't seem to work currently. Also * Updated service auth client. There's something strange here - the authclient didn't get updated on a compile, so I did it manually. * Deleted the unused baseclient in lib * Just fetched the one jar from `jars` rather than cloning the whole thing * Got rid of `six`
MrCreosote
force-pushed
the
dev-fix_build
branch
from
bbcfc70 to
4e47df6
Compare
MrCreosote
changed the title
|
Tests passed prior to force push, but coverage push failed because the Makefile needs to be updated, oops. Force pushed to get rid of GHA codecov block |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google download doesn't seem to work currently.
Also
jarsrather than cloning the whole thingsix