GHA fix #204
Merged
GHA fix #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xiangs18
requested review from
jsfillman,
jkbaumohl and
Tianhao-Gu
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #204 +/- ##
===========================================
- Coverage 65.00% 14.86% -50.14%
===========================================
Files 11 11
Lines 2886 2886
===========================================
- Hits 1876 429 -1447
- Misses 1010 2457 +1447 ☔ View full report in Codecov by Sentry. |
MrCreosote
reviewed
Jan 4, 2024
| @@ -51,7 +51,6 @@ build-test-script: | |||
| echo 'export PYTHONPATH=$$script_dir/../$(LIB_DIR):$$PATH:$$PYTHONPATH' >> $(TEST_DIR)/$(TEST_SCRIPT_NAME) | |||
| echo 'cd $$script_dir/../$(TEST_DIR)' >> $(TEST_DIR)/$(TEST_SCRIPT_NAME) | |||
| echo 'python -m nose --with-coverage --cover-package=$(SERVICE_CAPS) --cover-html --cover-html-dir=/kb/module/work/test_coverage --cover-xml --cover-xml-file=/kb/module/work/test_coverage/coverage.xml --nocapture --nologcapture .' >> $(TEST_DIR)/$(TEST_SCRIPT_NAME) | |||
| echo 'cp /kb/module/.coveragerc .' >> $(TEST_DIR)/$(TEST_SCRIPT_NAME) | |||
There was a problem hiding this comment.
Why are this and the other line dealing with .coveragerc not needed?
There was a problem hiding this comment.
- this file does not exist: https://github.com/kbaseapps/GenomeFileUtil/actions/runs/7404244710/job/20145462822#step:6:1100
- Upload coverage to Codecov step works fine without it
There was a problem hiding this comment.
Interesting, it looks like when coverage was added to this repo no one added a coveragerc but did add the line: 8005699
MrCreosote
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.