Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTV-1905 - add service widget support #3421

Open
wants to merge 107 commits into
base: develop
Choose a base branch
from

minor typing updates

73d74ff
Select commit
Loading
Failed to load commit list.
Open

PTV-1905 - add service widget support #3421

minor typing updates
73d74ff
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 17, 2024 in 0s

25.90% (-0.01%) compared to 90ed107, passed because coverage increased by 0.01% when compared to adjusted base (25.88%)

View this Pull Request on Codecov

25.90% (-0.01%) compared to 90ed107, passed because coverage increased by 0.01% when compared to adjusted base (25.88%)

Details

Codecov Report

Attention: Patch coverage is 23.43750% with 441 lines in your changes missing coverage. Please review.

Project coverage is 25.90%. Comparing base (90ed107) to head (73d74ff).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...nsion/static/kbase/js/util/cellSupport/CellBase.js 0.00% 107 Missing ⚠️
.../js/widgets/narrative_core/kbaseCellToolbarMenu.js 27.08% 70 Missing ⚠️
kbase-extension/static/kbase/js/kbaseNarrative.js 9.09% 50 Missing ⚠️
...e/js/widgets/serviceWidgetCell/AddServiceWidget.js 12.00% 44 Missing ⚠️
...ts/serviceWidgetCell/AddServiceWidgetDataViewer.js 12.50% 42 Missing ⚠️
...on/static/kbase/js/util/cellSupport/CellManager.js 0.00% 39 Missing ⚠️
kbase-extension/static/kbase/js/common/runtime.js 38.63% 27 Missing ⚠️
.../widgets/narrative_core/kbaseNarrativeWorkspace.js 8.33% 22 Missing ⚠️
nbextensions/appCell2/widgets/appCellWidget.js 0.00% 11 Missing ⚠️
...base-extension/static/kbase/js/common/cellUtils.js 47.36% 10 Missing ⚠️
... and 4 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3421      +/-   ##
===========================================
- Coverage    25.90%   25.90%   -0.01%     
===========================================
  Files          461      468       +7     
  Lines        46653    47194     +541     
===========================================
+ Hits         12085    12224     +139     
- Misses       34568    34970     +402     
Files with missing lines Coverage Δ
...ension/static/kbase/js/preactComponents/Loading.js 100.00% <100.00%> (ø)
...n/static/kbase/js/preactComponents/RotatedTable.js 100.00% <100.00%> (ø)
...base/js/widgets/narrative_core/narrativeViewers.js 65.04% <100.00%> (+1.41%) ⬆️
...-extension/static/kbase/js/common/pythonInterop.js 58.75% <0.00%> (-2.29%) ⬇️
...ion/static/kbase/js/preactComponents/ErrorAlert.js 81.25% <81.25%> (ø)
...-extension/static/kbase/js/util/bootstrapDialog.js 91.76% <54.54%> (-5.61%) ⬇️
kbase-extension/static/kbase/js/util/icon.js 86.76% <27.27%> (-5.43%) ⬇️
...base-extension/static/kbase/js/common/cellUtils.js 78.72% <47.36%> (-21.28%) ⬇️
nbextensions/appCell2/widgets/appCellWidget.js 63.05% <0.00%> (-0.72%) ⬇️
.../widgets/narrative_core/kbaseNarrativeWorkspace.js 56.84% <8.33%> (-10.83%) ⬇️
... and 7 more

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6b168c...73d74ff. Read the comment docs.