DATAUP-497: Removing old code relating to the defunct UJS #2713

ialarmedalien · 2022-01-21T23:37:07Z

Description of PR purpose/changes

Removing code and a bit of documentation relating to UJS, which is no longer in existence, sadly.
Closes #1634

Jira Ticket / Issue

Related Jira ticket: https://kbase-jira.atlassian.net/browse/DATAUP-497

Added the Jira Ticket to the title of the PR (e.g. DATAUP-69 Adds a PR template)

Testing Instructions

Details for how to test the PR:

Tests pass locally and in GitHub Actions
Changes available by spinning up a local narrative and navigating to X to see Y

Dev Checklist:

My code follows the guidelines at https://sites.google.com/lbl.gov/trussresources/home?authuser=0
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
(Python) I have run Black and Flake8 on changed Python code manually or with a git precommit hook

ialarmedalien · 2022-01-21T23:37:50Z

src/biokbase/narrative/clients.py

-        or client_name == "execution_engine"
-        or client_name == "job_service"
-    ):
+    elif client_name == "execution_engine2":


remove all the synonyms as we only ever use execution_engine2 in the codebase

ialarmedalien · 2022-01-21T23:38:04Z

src/biokbase/narrative/clients.py

        c = ServiceClient(URLS.service_wizard, use_url_lookup=True, token=token)
    elif client_name == "catalog":
        c = Catalog(URLS.catalog, token=token)
-    elif client_name == "user_and_job_state":


remove -- unused

codecov · 2022-01-21T23:40:40Z

Codecov Report

Merging #2713 (602d921) into DATAUP-497_job_message_cleanup_X (3629d50) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@                         Coverage Diff                          @@
##           DATAUP-497_job_message_cleanup_X    #2713      +/-   ##
====================================================================
+ Coverage                             24.59%   24.67%   +0.07%     
====================================================================
  Files                                   505      505              
  Lines                                 51842    51836       -6     
====================================================================
+ Hits                                  12753    12789      +36     
+ Misses                                39089    39047      -42

Impacted Files	Coverage Δ
kbase-extension/static/kbase/js/util/timeFormat.js	`71.65% <ø> (ø)`
src/biokbase/narrative/exception_util.py	`100.00% <ø> (ø)`
src/biokbase/narrative/clients.py	`95.65% <100.00%> (+18.72%)`	⬆️
.../widgets/function_output/samples/kbaseSampleSet.js	`93.33% <0.00%> (+1.33%)`	⬆️
kbase-extension/static/kbase/js/kbwidget.js	`41.55% <0.00%> (+5.19%)`	⬆️
...ets/function_output/GenomeClassifierTrainingSet.js	`69.81% <0.00%> (+11.32%)`	⬆️
...kbase/js/widgets/function_output/kbaseAlignment.js	`63.82% <0.00%> (+12.76%)`	⬆️
...tatic/kbase/js/widgets/kbaseAuthenticatedWidget.js	`53.33% <0.00%> (+26.66%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3629d50...602d921. Read the comment docs.