Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CE-372 #53

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

CE-372 #53

wants to merge 11 commits into from

Conversation

eapearson
Copy link
Contributor

@eapearson eapearson commented May 17, 2024

Pull Request

Description

Minor dependency updates (keeping fresh) and one new environment variable to allow setting the link return url (useful for switching from kbase-ui -> Europa).

NOTE - this PR and associated branch could remain open until the Europa/orcidlink integration is complete, in case further changes are warranted. In addition, there code cleanup and documentation are called for at some point.

Issues Resolved

CE-272

Testing Instructions

One needs to have bash and docker installed.

git clone https://github.com/kbase/kbase-service-orcidlink
cd kbase-service-orcidlink
./Taskfile test
  • Tests pass locally
  • Tests and build pass in GitHub actions
  • Manually verified that changes are available (if applicable)

Dev Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run the code quality tools against the codebase

Release Notes - Development

This section only relevant to a PR against develop

  • Ensure there is an "Unreleased" section located at the top of RELEASE_NOTES.md
  • Add relevant notes to Unreleased

Release

This section only relevant if this PR is preparing a release

  • [ ] Rename the "Unreleased" section to the appropriate release, and create a new, empty "Ureleased" section at the top

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant