Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Token Via File #372

Closed
wants to merge 1 commit into from
Closed

Pass Token Via File #372

wants to merge 1 commit into from

Conversation

bio-boris
Copy link
Contributor

@MrCreosote
Copy link
Member

Unfortunately this will cause all Java apps to break, probably cause all Perl apps to break, and I presume cause python apps compiled before the token file feature was added to break

@bio-boris
Copy link
Contributor Author

Is this file used for generating templates in kb-sdk init? If so, wouldn't it mean that new apps would generate the async file this way and not affect existing python modules? I'm putting this here as a possible thing to include we can add in the kb-sdk:python fork. I will close this and use an issue instead.

@bio-boris bio-boris mentioned this pull request Apr 13, 2024
@bio-boris bio-boris closed this Apr 13, 2024
@MrCreosote
Copy link
Member

Is this file used for generating templates in kb-sdk init? If so, wouldn't it mean that new apps would generate the async file this way and not affect existing python modules?

I'm not sure if it's init or compile, probably init, in which case only new java & perl apps would break

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants