Switch to two stage build #355
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #355 +/- ##
=========================================
Coverage 93.3% 93.3%
Complexity 1469 1469
=========================================
Files 100 100
Lines 4448 4448
Branches 757 757
=========================================
Hits 4150 4150
Misses 282 282
Partials 16 16 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #355 +/- ##
=========================================
Coverage 93.3% 93.3%
Complexity 1469 1469
=========================================
Files 100 100
Lines 4448 4448
Branches 757 757
=========================================
Hits 4150 4150
Misses 282 282
Partials 16 16 |
MrCreosote
reviewed
Feb 20, 2019
|
|
||
| # The BUILD_DATE value seem to bust the docker cache when the timestamp changes, move to | ||
| # the end | ||
| LABEL org.label-schema.build-date=$BUILD_DATE \ |
There was a problem hiding this comment.
Was this intentionally deleted? it's been part of the build variables for a long time.
There was a problem hiding this comment.
Yes. The automated dockerrhub builds don't have a way to pass parameters dynamically.
| org.label-schema.vcs-url="https://github.com/kbase/groups.git" \ | ||
| org.label-schema.vcs-ref=$VCS_REF \ | ||
| org.label-schema.vcs-ref=$SOURCE_COMMIT \ |
There was a problem hiding this comment.
Will these changes break the travis build?
There was a problem hiding this comment.
These would replace the builds on travis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And prepare for using automated builds on dockerhub.