Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka support #63

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Kafka support #63

wants to merge 13 commits into from

Conversation

briehl
Copy link
Member

@briehl briehl commented Feb 12, 2019

Start the Kafka listener with make start_kafka_listener.

Still needs tests, but I want to see them pass on Travis as-is, with the config changes.

@coveralls
Copy link

coveralls commented Feb 12, 2019

Pull Request Test Coverage Report for Build 227

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 89.903%

Totals Coverage Status
Change from base Build 217: -0.5%
Covered Lines: 1576
Relevant Lines: 1753

💛 - Coveralls

@briehl
Copy link
Member Author

briehl commented Feb 13, 2019

This works when tested locally with a local Kafka install, but it doesn't like testing on Travis-CI. Not sure why. Either way, this work isn't critical for the GSP, so I propose we wait a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants