Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added indexes #425

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Added indexes #425

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
695d10b
Added indexes
Nov 4, 2021
ce64fd2
Oh can run .explain() to see if its working
Nov 4, 2021
874275a
Update models.py
bio-boris Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/execution_engine2/db/models/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,11 @@ class Job(Document):
default=False
) # Marked true when all retry steps have completed

meta = {"collection": "ee2_jobs"}
# See https://docs.mongoengine.org/guide/defining-documents.html#indexes
# Hmm, are these indexes need to be + or - ?
Copy link
Member

@MrCreosote MrCreosote Nov 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on if you want sorted results - if not, it doesn't really matter. With the status/queued index, if you do an equality query on status and a range query on queued you can sort descending on the queue time without having to do an in-memory sort. Ascending sorts would be in memory.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, with the change now oldest first sorts can be done without an in-memory sort

indexes = [("status", "batch_job"), ("status", "queued")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the query for the status/batch_job index?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kbase/execution_engine2/blob/develop/bin/PurgeBadJobs.py#L103


meta = {"collection": "ee2_jobs", "indexes": indexes}

def save(self, *args, **kwargs):
self.updated = time.time()
Expand Down