Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback server wrapper #554

Closed
wants to merge 3 commits into from
Closed

Callback server wrapper #554

wants to merge 3 commits into from

Conversation

Xiangs18
Copy link
Collaborator

This PR updates and relocates the original workspace_downloader_helper.py file

  1. updated/tested the workspace_downloader.py script
  2. Will update workspace_uploader.py in RE2022-217: Workspace uploader performance #426

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (170017a) 46.90% compared to head (1a8fc2c) 46.83%.

Files Patch % Lines
src/loaders/common/callback_server_wrapper.py 0.00% 19 Missing ⚠️
...aders/workspace_downloader/workspace_downloader.py 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   46.90%   46.83%   -0.08%     
==========================================
  Files          73       73              
  Lines        6306     6318      +12     
==========================================
+ Hits         2958     2959       +1     
- Misses       3348     3359      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCreosote
Copy link
Member

So this PR was just supposed to be rename & relocate - no changes. The changes should show up in the other PR where they're part of the set of changes to support the new assemblyutil parallelization

@Xiangs18 Xiangs18 closed this Nov 29, 2023
@Xiangs18 Xiangs18 deleted the callback_server_wrapper branch January 18, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants