add R script #256
Merged
add R script #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
==========================================
- Coverage 47.48% 47.19% -0.29%
==========================================
Files 49 49
Lines 3513 3545 +32
==========================================
+ Hits 1668 1673 +5
- Misses 1845 1872 +27
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
MrCreosote
reviewed
Apr 13, 2023
MrCreosote
previously approved these changes
Apr 14, 2023
|
Looks like there are some image building problems to deal with before this can be merged though |
Tianhao-Gu
commented
Apr 14, 2023
| @@ -28,6 +28,7 @@ coverage = "==7.2.2" | |||
| pytest-cov = "==4.0.0" | |||
| ipython = "==8.12.0" | |||
| pytest-asyncio = "==0.21.0" | |||
| rpy2 = "==3.5.10" | |||
There was a problem hiding this comment.
move rpy2 temporally to dev-packages so that docker image can be built. create a ticket to fix it later.
https://kbase-jira.atlassian.net/browse/RE2022-149
|
.. and now codecov is choking |
MrCreosote
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.