Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update design re presigned urls and tar uploads #26

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

MrCreosote
Copy link
Member

  • tar uploads aren't a general solution for all uploads as they have a GB limit
  • Clarify how presigning upload URLs will work.

* tar uploads aren't a general solution for all uploads as they have a
GB limit
* Clarify how presigning upload URLs will work.
@MrCreosote MrCreosote requested a review from Tianhao-Gu August 27, 2024 22:22
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (deb7ad5) to head (407f679).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files           6        6           
  Lines         273      273           
=======================================
  Hits          270      270           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Tianhao-Gu Tianhao-Gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@MrCreosote MrCreosote merged commit 512c44a into main Aug 28, 2024
11 checks passed
@MrCreosote MrCreosote deleted the dev-design branch August 28, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants