Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registration info to the image structure & a GET endpoint. #164

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

MrCreosote
Copy link
Member

No description provided.

@MrCreosote MrCreosote requested a review from Tianhao-Gu January 10, 2025 20:20
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 52.17391% with 11 lines in your changes missing coverage. Please review.

Project coverage is 54.38%. Comparing base (2390381) to head (0edfb8a).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
cdmtaskservice/images.py 44.44% 5 Missing ⚠️
cdmtaskservice/job_state.py 33.33% 2 Missing ⚠️
cdmtaskservice/routes.py 66.66% 2 Missing ⚠️
cdmtaskservice/app.py 0.00% 1 Missing ⚠️
cdmtaskservice/app_state.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   54.32%   54.38%   +0.06%     
==========================================
  Files          34       34              
  Lines        2222     2234      +12     
==========================================
+ Hits         1207     1215       +8     
- Misses       1015     1019       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Tianhao-Gu Tianhao-Gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As we develop the API, I’m feeling more uncertain about how comfortable the team will feel using it. Overall, the task service demands more effort than simply setting up and running a local tool—something people already seem reluctant/having trouble to do, in my opinion. We should sync with the science team to ensure they’re open to drafting a Docker file, registering images, and using the system to schedule jobs. It was intentionally designed this way, but I feel that people often gain a clearer understanding when they see the final product or how the API is actually used.

@MrCreosote
Copy link
Member Author

Let's talk about it on Tuesday, but if we want to run reproducible tasks on NERSC there isn't really another reasonable option other than containers.

drafting a Docker file

I suspect that the tech team will be doing that, at least early on. That being said, the CTS is designed to make this as trivial as possible

registering images

Only system admins can do that

schedule jobs

This is the one that users will be doing a lot. I'm pretty sure we're going to need some sort of UI, but we'll see

@MrCreosote MrCreosote merged commit 5b95708 into main Jan 10, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants