Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge job_submit back into job_state #162

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Merge job_submit back into job_state #162

merged 1 commit into from
Jan 10, 2025

Conversation

MrCreosote
Copy link
Member

oops

@MrCreosote MrCreosote requested a review from Tianhao-Gu January 10, 2025 18:05
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 30 lines in your changes missing coverage. Please review.

Project coverage is 54.08%. Comparing base (12fe342) to head (486749a).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
cdmtaskservice/job_state.py 28.94% 27 Missing ⚠️
cdmtaskservice/routes.py 0.00% 2 Missing ⚠️
cdmtaskservice/app_state.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
- Coverage   54.18%   54.08%   -0.10%     
==========================================
  Files          35       34       -1     
  Lines        2224     2215       -9     
==========================================
- Hits         1205     1198       -7     
+ Misses       1019     1017       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Tianhao-Gu Tianhao-Gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MrCreosote MrCreosote merged commit 2adef65 into main Jan 10, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants