Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a poller for JAWS jobs #158

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Add a poller for JAWS jobs #158

merged 1 commit into from
Jan 9, 2025

Conversation

MrCreosote
Copy link
Member

No description provided.

@MrCreosote MrCreosote requested a review from Tianhao-Gu January 9, 2025 16:34
@MrCreosote
Copy link
Member Author

Codecov seems to be consistently very slow in the AM

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 31.81818% with 30 lines in your changes missing coverage. Please review.

Project coverage is 54.80%. Comparing base (765dec3) to head (3e9c76d).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
cdmtaskservice/jaws/poller.py 32.14% 19 Missing ⚠️
cdmtaskservice/jaws/client.py 22.22% 7 Missing ⚠️
cdmtaskservice/jobflows/nersc_jaws.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
- Coverage   55.24%   54.80%   -0.45%     
==========================================
  Files          34       35       +1     
  Lines        2134     2175      +41     
==========================================
+ Hits         1179     1192      +13     
- Misses        955      983      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Tianhao-Gu Tianhao-Gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MrCreosote MrCreosote merged commit 7e280f5 into main Jan 9, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants