Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle uncaught exceptions in coroutine manager and simplify #139

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

MrCreosote
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 55.10%. Comparing base (1fb9a4e) to head (6f7d372).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cdmtaskservice/coroutine_manager.py 25.00% 9 Missing ⚠️
cdmtaskservice/app_state.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   55.08%   55.10%   +0.01%     
==========================================
  Files          32       32              
  Lines        1946     1940       -6     
==========================================
- Hits         1072     1069       -3     
+ Misses        874      871       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCreosote MrCreosote changed the title Handle uncaught exceptions in corotine manager and simplify Handle uncaught exceptions in coroutine manager and simplify Dec 20, 2024
Copy link
Collaborator

@Tianhao-Gu Tianhao-Gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrCreosote MrCreosote merged commit 289a6be into main Dec 20, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants