Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate wdl and input.json files for job submit #136

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

MrCreosote
Copy link
Member

Moved the code into the NERSC manager as it makes sense for it to figure out the various file paths

Moved the code into the NERSC manager as it makes sense for it to figure
out the various file paths
Comment on lines -147 to -148
# If we support multiple compute sites this should be moved to a general code location
# Currently leave here rather than creating yet another module
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that idea didn't last

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 24.59016% with 46 lines in your changes missing coverage. Please review.

Project coverage is 55.23%. Comparing base (38079c7) to head (9e18e84).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cdmtaskservice/nersc/manager.py 29.41% 24 Missing ⚠️
cdmtaskservice/manifest_files.py 20.00% 20 Missing ⚠️
cdmtaskservice/jobflows/nersc_jaws.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   55.38%   55.23%   -0.15%     
==========================================
  Files          31       32       +1     
  Lines        1914     1939      +25     
==========================================
+ Hits         1060     1071      +11     
- Misses        854      868      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCreosote MrCreosote merged commit 620d1db into main Dec 20, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants