Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callbacks for download and job complete #132

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Add callbacks for download and job complete #132

merged 1 commit into from
Dec 17, 2024

Conversation

MrCreosote
Copy link
Member

Not sure if job complete is going to be needed, will delete if not

Not sure if job complete is going to be needed, will delete if not
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.

Project coverage is 56.20%. Comparing base (f82c102) to head (46fc710).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cdmtaskservice/routes.py 66.66% 4 Missing ⚠️
cdmtaskservice/app.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   55.85%   56.20%   +0.35%     
==========================================
  Files          31       31              
  Lines        1837     1854      +17     
==========================================
+ Hits         1026     1042      +16     
- Misses        811      812       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Tianhao-Gu Tianhao-Gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MrCreosote MrCreosote merged commit e1733da into main Dec 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants