Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split job submit from job state #126

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Split job submit from job state #126

merged 1 commit into from
Dec 11, 2024

Conversation

MrCreosote
Copy link
Member

The nersc / jaws flow manager has a dependency on job state as it'll need to get and update the state. The job submission code will have a dependency on the ners / jaws flow manager, and so needs to be split out to avoid a circular import.

The nersc / jaws flow manager has a dependency on job state as it'll
need to get and update the state. The job submission code will have a
dependency on the ners / jaws flow manager, and so needs to be split out
to avoid a circular import.
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 36.95652% with 29 lines in your changes missing coverage. Please review.

Project coverage is 56.14%. Comparing base (f7eb823) to head (944b7a6).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
cdmtaskservice/job_submit.py 34.21% 25 Missing ⚠️
cdmtaskservice/app_state.py 50.00% 2 Missing ⚠️
cdmtaskservice/routes.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
+ Coverage   56.00%   56.14%   +0.13%     
==========================================
  Files          29       30       +1     
  Lines        1764     1774      +10     
==========================================
+ Hits          988      996       +8     
- Misses        776      778       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Tianhao-Gu Tianhao-Gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MrCreosote MrCreosote merged commit a591575 into main Dec 11, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants