update jupterhub config to enable docker spanwer #98
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
- Coverage 47.75% 47.51% -0.24%
==========================================
Files 7 7
Lines 400 402 +2
==========================================
Hits 191 191
- Misses 209 211 +2 ☔ View full report in Codecov by Sentry. |
| c.DockerSpawner.network_name = network_name | ||
| c.DockerSpawner.use_internal_ip = True | ||
| environment = os.environ.get('ENVIRONMENT', 'prod').lower() | ||
| c.DockerSpawner.remove = environment != 'dev' |
There was a problem hiding this comment.
Can you add a comment describing the purpose of this line?
There was a problem hiding this comment.
Under what conditions does the container get removed?
There was a problem hiding this comment.
when the container stops (error, user can also manually restart spawner).
There was a problem hiding this comment.
user can also manually restart spawner
Here you're talking about the user image right? Not the user image spawner?
How would the user restart the spawner?
Can you update the comment to explain when the image is removed?
There was a problem hiding this comment.
Here you're talking about the user image right? Not the user image spawner?
yea the user image. Not jupyterhub server.
How would the user restart the spawner?
On the home page, users can stop and restart server. Similar to NERSC.
| # Created by `docker network create cdm-jupyterhub-network` | ||
| cdm-jupyterhub-network: | ||
| external: true |
There was a problem hiding this comment.
it indicates the network is created by docker network create. I wasn't able to get it working locally with docker compose created networks.
There was a problem hiding this comment.
What implications does that have?
Do you have to do something similar in Rancher?
There was a problem hiding this comment.
I am working with Devops on this.
There was a problem hiding this comment.
Ok, so it's not clear what's going to happen in rancher yet.
I still don't understand what the difference is between the two network modes in docker compose
There was a problem hiding this comment.
With the one docker compose created automatically, I couldn't get jupterhub working locally. Hostname is not resolved correctly which is what we see in Rancher now. I don't know I have the best answer for this question. Still trying to figure it out. But with this setting, at least I can get jupterhub working properly locally with docker compose.
There was a problem hiding this comment.
Ok, sounds like this is "well it works but I don't know why" situation.
The reason I was asking this is because I don't know how that would translate to Rancher and if it'd have any security implications
There was a problem hiding this comment.
yea. I think I will try to understand and how it works in Rancher and maybe come back and update docker compose to make it similar if not the same as Rancher.
No description provided.