fix hub permission issue #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
==========================================
- Coverage 72.48% 68.37% -4.12%
==========================================
Files 5 5
Lines 229 234 +5
==========================================
- Hits 166 160 -6
- Misses 63 74 +11 ☔ View full report in Codecov by Sentry. |
Tianhao-Gu
commented
Sep 16, 2024
|
|
||
| # TODO: Set directory permissions to 750 or 700 or switch to use docker spawner | ||
| # Set directory permissions to 777: Owner (rwx), Group (rwx), Others (rwx) | ||
| subprocess.run(['sudo', 'chmod', '-R', '777', user_dir], check=True) |
There was a problem hiding this comment.
After exploring DockerSpawner, I'm confident that switching to it will resolve the issue, as each user's directory is mounted individually per container.
MrCreosote
reviewed
Sep 16, 2024
| @@ -237,11 +201,6 @@ def test_ensure_user_directory_reuse_existing(mock_chown, mock_chmod, caplog): | |||
| spawner = VirtualEnvSpawner() | |||
| spawner._ensure_user_directory(user_dir, username) | |||
|
|
|||
| # Check that mkdir, chown, and chmod were not called since directory exists | |||
| assert user_dir.exists() | |||
There was a problem hiding this comment.
Seems like you should keep this line
Co-authored-by: MrCreosote <[email protected]>
MrCreosote
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
spark_user, which runs the JupyterHub, needs access to users' directories to update Jupyter runtime data. However, despite setting directory permissions to770and assigning the correct group tospark_user, it still encounters access issues. As a temporary solution, we have set the directories to777, hoping this will be resolved when we switch to Docker spawner.