Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using ghcr.io/kbase img for standalone spark deployment #75

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

Tianhao-Gu
Copy link
Collaborator

Screenshot 2024-08-29 at 10 15 27 AM

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.76%. Comparing base (1d4f084) to head (d3482c2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   48.76%   48.76%           
=======================================
  Files           4        4           
  Lines         121      121           
=======================================
  Hits           59       59           
  Misses         62       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCreosote
Copy link
Member

This is just the prelude to pulling things out of the image to slim it down? What can you actually remove? You still need the spark libs right?

Comment on lines +10 to +11
# Images from the ghcr.io/kbase registry are exclusively available for Linux/AMD64 platforms.
platform: linux/amd64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fix the mac issues?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Without this, docker compose won't run on Mac machines since it cannot find the arm64 version. I used to manually modify docker-compose file before running it.

Copy link
Member

@MrCreosote MrCreosote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in any case

@Tianhao-Gu
Copy link
Collaborator Author

This is just the prelude to pulling things out of the image to slim it down? What can you actually remove? You still need the spark libs right?

I will test and see if I can remove any spark libs in the next PRs. I want to do this little by little so that I can test in CI since local yarn doesn't work for me.

@Tianhao-Gu Tianhao-Gu merged commit abf2812 into main Aug 29, 2024
8 of 9 checks passed
@Tianhao-Gu Tianhao-Gu deleted the dev_switch_spark_standalone_img branch August 29, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants