-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using ghcr.io/kbase img for standalone spark deployment #75
Conversation
Tianhao-Gu
commented
Aug 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
=======================================
Coverage 48.76% 48.76%
=======================================
Files 4 4
Lines 121 121
=======================================
Hits 59 59
Misses 62 62 ☔ View full report in Codecov by Sentry. |
This is just the prelude to pulling things out of the image to slim it down? What can you actually remove? You still need the spark libs right? |
# Images from the ghcr.io/kbase registry are exclusively available for Linux/AMD64 platforms. | ||
platform: linux/amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this fix the mac issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Without this, docker compose won't run on Mac machines since it cannot find the arm64 version. I used to manually modify docker-compose file before running it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in any case
I will test and see if I can remove any spark libs in the next PRs. I want to do this little by little so that I can test in CI since local yarn doesn't work for me. |