Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional arg for minio_client #73

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

Tianhao-Gu
Copy link
Collaborator

No description provided.

@MrCreosote
Copy link
Member

Oops, tests are failing. Need a fix there I guess

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 48.76%. Comparing base (19cdfb6) to head (93c406b).
Report is 2 commits behind head on main.

Files Patch % Lines
src/minio_utils/minio_utils.py 25.00% 3 Missing ⚠️
src/spark/utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   50.00%   48.76%   -1.24%     
==========================================
  Files           4        4              
  Lines         118      121       +3     
==========================================
  Hits           59       59              
- Misses         59       62       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tianhao-Gu
Copy link
Collaborator Author

Oops, tests are failing. Need a fix there I guess

codecov error. Passed on rerunning the workflow.

@Tianhao-Gu Tianhao-Gu merged commit b8d5fd8 into main Aug 27, 2024
7 of 10 checks passed
@Tianhao-Gu Tianhao-Gu deleted the dev_optional_arg_minio_client branch August 27, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants