add spark helper #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrCreosote
reviewed
May 20, 2024
| @@ -63,23 +63,37 @@ When running Spark in the Jupyter notebook container, the default `spark.driver. | |||
| the hostname (`SPARK_DRIVER_HOST`) of the container. | |||
| In addition, the environment variable `SPARK_MASTER_URL` should also be configured. | |||
|
|
|||
| #### Using Predefined SparkSession from `spark.utils.get_spark_session` method | |||
| ```python | |||
| from spark.utils import get_spark_session | |||
There was a problem hiding this comment.
Will spark not conflict with other package names?
There was a problem hiding this comment.
I don't think so. But just in case changed the repo name to common.
There was a problem hiding this comment.
common seems like it'd conflict too
There was a problem hiding this comment.
https://pypi.org/project/common/ seems dead.
That being said, https://pypi.org/project/spark/ seems super dead
There was a problem hiding this comment.
So spark seems safe and is probably a better name, sorry about that
src/__init__.py
Outdated
There was a problem hiding this comment.
I don't think __init__ files are necessary any more
MrCreosote
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.