add jupyterlab git extension #35
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
=======================================
Coverage 48.07% 48.07%
=======================================
Files 4 4
Lines 104 104
=======================================
Hits 50 50
Misses 54 54 ☔ View full report in Codecov by Sentry. |
docker-compose.yaml
Outdated
| @@ -163,7 +163,7 @@ services: | |||
| postgres: | |||
| image: postgres:16.3 | |||
| restart: always | |||
| container_name: postgres | |||
| container_name: postgres_spark | |||
There was a problem hiding this comment.
I don't see any reason to do this - seems fine as is.
There was a problem hiding this comment.
so that we don't need to manually delete postgres container if we run docker-compose on this repo and on hive repo since they both have a postgres container.
There was a problem hiding this comment.
actually, I revert the container name changes. We need to update POSTGRES_URL for every other dependencies. It's not worth it.
There was a problem hiding this comment.
Plus I suspect we'll need to use the hive only compose file rarely at best.
There was a problem hiding this comment.
if we're going to change it we should change it there
| @@ -15,6 +15,7 @@ sparkmonitor = "==3.0.2" | |||
| itables = "==2.1.1" | |||
| PyMySQL = "==1.1.1" | |||
| urllib3 = "==2.2.2" | |||
| jupyterlab-git = "==0.50.1" | |||
There was a problem hiding this comment.
Do docs need to be added to explain to users how to make use of this?
There was a problem hiding this comment.
I think it's pretty self-explanatory as the extension added an UI component. Users don't need to do any extra steps to enable this.
No description provided.