Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vol mount #3

Closed
wants to merge 2 commits into from
Closed

add vol mount #3

wants to merge 2 commits into from

Conversation

Tianhao-Gu
Copy link
Collaborator

No description provided.

- SPARK_DRIVER_HOST=spark-notebook
volumes:
- ./cdm_shared_workspace:/cdm_shared_workspace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are you mounting from in rancher?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in Rancher I just do /cdm_shared_workspace:/cdm_shared_workspace.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does the data live though? In the VM the notebook is running on?

Copy link
Collaborator Author

@Tianhao-Gu Tianhao-Gu May 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. I am double confirming it with devops team in slack.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we'll probably have to think about how different users would interact with this but that's much later

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bcc0e28) to head (41cc14d).

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            9         9           
=========================================
  Hits             9         9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCreosote
Copy link
Member

is this still relevant?

@Tianhao-Gu Tianhao-Gu closed this May 23, 2024
@Tianhao-Gu Tianhao-Gu deleted the dev_notebook branch May 23, 2024 21:07
@Tianhao-Gu
Copy link
Collaborator Author

is this still relevant?

no. Just closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants