add minio client helper #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 60.71% 61.66% +0.95%
==========================================
Files 2 3 +1
Lines 56 60 +4
==========================================
+ Hits 34 37 +3
- Misses 22 23 +1 ☔ View full report in Codecov by Sentry. |
MrCreosote
reviewed
Jun 6, 2024
| :return: A Minio client object | ||
| """ | ||
| return Minio( | ||
| os.environ['MINIO_URL'].replace("http://", ""), |
There was a problem hiding this comment.
here I'm wondering why we're just not excluding http:// in the env var in rancher. Is there a reason for that?
There was a problem hiding this comment.
tested removing http:// from docker-compose file. When I tried to read delta files, it took 10 minutes without returning anything. I am guessing it's needed for spark custom s3 endpoint config.
MrCreosote
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.