add driver_host to spark config #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tianhao-Gu
commented
May 16, 2024
| if [ -n "$SPARK_DRIVER_HOST" ]; then | ||
| echo "Setting spark.driver.host to $SPARK_DRIVER_HOST" | ||
| source /opt/bitnami/scripts/spark-env.sh | ||
| if [ -z "$SPARK_CONF_FILE" ]; then |
There was a problem hiding this comment.
@MrCreosote I think the previous attempt to write to the Spark config file failed because we didn't set $SPARK_CONF_FILE.
MrCreosote
reviewed
May 16, 2024
There was a problem hiding this comment.
Does this work in the CI or CDM stack?
There was a problem hiding this comment.
yea. I already deployed the new image in the CDM namespace and tested it.
| @@ -2,6 +2,16 @@ | |||
|
|
|||
| echo "starting jupyter notebook" | |||
|
|
|||
| if [ -n "$SPARK_DRIVER_HOST" ]; then | |||
| echo "Setting spark.driver.host to $SPARK_DRIVER_HOST" | |||
| source /opt/bitnami/scripts/spark-env.sh | |||
There was a problem hiding this comment.
This is to get the conf file env var?
There was a problem hiding this comment.
yea. I think this is the script bitnami is using to load all env variables. It only has export commands.
Comment on lines
75
to
77
| conf = SparkConf(). \ | ||
| setMaster( os.environ['SPARK_MASTER_URL']). \ | ||
| setAppName("TestSparkJob"). \ | ||
| set("spark.driver.host", os.environ['SPARK_DRIVER_HOST']) | ||
| setAppName("TestSparkJob") | ||
| sc = SparkContext(conf=conf) |
MrCreosote
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.