clean docker compose file #119
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
=======================================
Coverage 41.94% 41.94%
=======================================
Files 7 7
Lines 503 503
=======================================
Hits 211 211
Misses 292 292 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
| depends_on: | ||
| - spark-master |
There was a problem hiding this comment.
This seems like it'd be necessary? Does it not matter?
There was a problem hiding this comment.
It really doesn't matter now. I think at one time we might even remove stand alone spark. It slows down docker compose up/down. I can add it back but I think it's okay to leave it out.
| ports: | ||
| - "4043:4043" | ||
| depends_on: | ||
| - spark-master |
There was a problem hiding this comment.
Same question here. Seems like it should also depend on yarn
| @@ -231,6 +160,7 @@ services: | |||
| - NETWORK_NAME=cdm-jupyterhub-network | |||
| - JUPYTERHUB_USER_IMAGE=cdm-jupyterhub-cdm_jupyterhub:latest | |||
| - JUPYTERHUB_MOUNT_BASE_DIR=/cdr/cdm/jupyter | |||
| - ENVIRONMENT=dev | |||
There was a problem hiding this comment.
Is there no user hub instance?
There was a problem hiding this comment.
no. Just one hub instance and permissions are controlled via user groups.
There was a problem hiding this comment.
What does the ENVIRONMENT variable do in that case?
There was a problem hiding this comment.
There was a problem hiding this comment.
I'd probably give that env var a more descriptive name in that case, like REMOVE_CONTAINER or something
There was a problem hiding this comment.
It's okay. I might need this env var to differentiate between the production and test environments for other purposes. There are already so many env vars.
No description provided.