Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add idle timeout #118
add idle timeout #118
Changes from 1 commit
7ba01d2
1c0d0b5
1f805b6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 20 in src/jupyterhub_config/custom_docker_spawner.py
Codecov / codecov/patch
src/jupyterhub_config/custom_docker_spawner.py#L20
Check warning on line 57 in src/jupyterhub_config/custom_docker_spawner.py
Codecov / codecov/patch
src/jupyterhub_config/custom_docker_spawner.py#L55-L57
Check warning on line 81 in src/jupyterhub_config/custom_docker_spawner.py
Codecov / codecov/patch
src/jupyterhub_config/custom_docker_spawner.py#L80-L81
Check warning on line 83 in src/jupyterhub_config/custom_docker_spawner.py
Codecov / codecov/patch
src/jupyterhub_config/custom_docker_spawner.py#L83
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this must be running in the central hub server since it's polling against possibly stopped containers. Is there a CustomDockerSpawner instance per user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea. each user will have a spawner instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Check warning on line 86 in src/jupyterhub_config/custom_docker_spawner.py
Codecov / codecov/patch
src/jupyterhub_config/custom_docker_spawner.py#L85-L86
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utcnow()
isn't recommended: https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnowThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure timezone info isn't necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, both
utcnow()
andnow()
are working as expected locally.last_activity = self.user.last_activity
doesn't have timezone info either.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Check warning on line 90 in src/jupyterhub_config/custom_docker_spawner.py
Codecov / codecov/patch
src/jupyterhub_config/custom_docker_spawner.py#L88-L90
Check warning on line 95 in src/jupyterhub_config/custom_docker_spawner.py
Codecov / codecov/patch
src/jupyterhub_config/custom_docker_spawner.py#L92-L95
Check warning on line 98 in src/jupyterhub_config/custom_docker_spawner.py
Codecov / codecov/patch
src/jupyterhub_config/custom_docker_spawner.py#L98