try not limit container resource #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
=======================================
Coverage 42.94% 42.94%
=======================================
Files 7 7
Lines 482 482
=======================================
Hits 207 207
Misses 275 275 ☔ View full report in Codecov by Sentry. |
MrCreosote
reviewed
Nov 12, 2024
Comment on lines
+53
to
+54
| c.DockerSpawner.http_timeout = 120 # 2 minutes (default is 30 seconds) | ||
| c.DockerSpawner.start_timeout = 300 # 5 minutes (default is 60 seconds) |
There was a problem hiding this comment.
Could you add comments describing what each timeout is waiting for? Is http_timeout waiting to make contact with the new container, and start waiting for the container to publish it's status as started or something?
There was a problem hiding this comment.
added a ref link in the overhead section. I don’t think every setting needs to be documented.
MrCreosote
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.