create bashrc file #108
create bashrc file #108
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
==========================================
- Coverage 44.27% 43.12% -1.16%
==========================================
Files 7 7
Lines 463 480 +17
==========================================
+ Hits 205 207 +2
- Misses 258 273 +15 ☔ View full report in Codecov by Sentry. |
| shutil.copy2(bashrc_ext_src, user_dir/'.bashrc.tmpl') | ||
| shutil.copy2(bash_profile_ext_src, user_dir/'.bash_profile.tmpl') | ||
|
|
||
| bashrc_dest = user_dir / '.bashrc' | ||
| bash_profile_dest = user_dir / '.bash_profile' | ||
|
|
||
| if not bashrc_dest.exists(): | ||
| self.log.info(f'Creating .bashrc file for {user_dir}') | ||
| shutil.copy2(bashrc_ext_src, bashrc_dest) |
There was a problem hiding this comment.
Why copy twice? Seems like just copying from the config dir directly to *_dest would work
There was a problem hiding this comment.
just want to keep a copy of the template available for users to reference in case they update their .bashrc file and are unable to recover it.
There was a problem hiding this comment.
Can you add a comment to that effect? Will probably confuse future ppl working on this and they might simplify things w/o realizing your intent
No description provided.