Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set usage_mode #106

Merged
merged 1 commit into from
Oct 16, 2024
Merged

set usage_mode #106

merged 1 commit into from
Oct 16, 2024

Conversation

Tianhao-Gu
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.27%. Comparing base (e35b8c4) to head (bb860f2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/jupyterhub_config/custom_docker_spawner.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
- Coverage   44.37%   44.27%   -0.10%     
==========================================
  Files           7        7              
  Lines         462      463       +1     
==========================================
  Hits          205      205              
- Misses        257      258       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +118 to +119
# USAGE_MODE is used by the setup.sh script to determine the appropriate configuration for the user.
self.environment['USAGE_MODE'] = 'dev'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does setup.sh get run after this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.

@Tianhao-Gu Tianhao-Gu merged commit 73d0ad5 into main Oct 16, 2024
7 of 10 checks passed
@Tianhao-Gu Tianhao-Gu deleted the dev_jupyterhub branch October 16, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants