add shared dir to user's favorite list #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
- Coverage 45.32% 45.22% -0.11%
==========================================
Files 7 7
Lines 428 429 +1
==========================================
Hits 194 194
- Misses 234 235 +1 ☔ View full report in Codecov by Sentry. |
MrCreosote
reviewed
Oct 1, 2024
| @@ -98,6 +98,11 @@ ENV CDM_SHARED_DIR=/cdm_shared_workspace | |||
| RUN mkdir -p ${CDM_SHARED_DIR} && chmod -R 777 ${CDM_SHARED_DIR} | |||
| RUN chown -R spark_user:spark $CDM_SHARED_DIR | |||
|
|
|||
| # TODO: Config through a config file or DB as the number of groups increases. | |||
There was a problem hiding this comment.
How are you thinking this is going to work? Is there going to be a mount per group?
There was a problem hiding this comment.
I am thinking in long-term plan, we will first get a list of dirs that are shared to the login user. And then mount those dir to that user.
MrCreosote
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.