Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using gradle for Jars #10

Merged
merged 6 commits into from
May 28, 2024
Merged

using gradle for Jars #10

merged 6 commits into from
May 28, 2024

Conversation

Tianhao-Gu
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.57%. Comparing base (720d734) to head (8631a98).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   78.57%   78.57%           
=======================================
  Files           1        1           
  Lines          28       28           
=======================================
  Hits           22       22           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Dockerfile Outdated
Comment on lines 12 to 17
# Install Gradle
ENV GRADLE_VERSION=8.7
RUN curl -L https://services.gradle.org/distributions/gradle-${GRADLE_VERSION}-bin.zip -o gradle-bin.zip \
&& unzip gradle-bin.zip -d /opt \
&& rm gradle-bin.zip \
&& ln -s /opt/gradle-${GRADLE_VERSION}/bin/gradle /usr/bin/gradle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should gradle init the repo and then use the gradle wrapper file here to install the jars

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out any of the java services for examples

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run gradle init locally? or with dockerfile? I just need to download the jars not turning this to a java project.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run gradle init in the repo locally, that'll set up gradle correctly with a wrapper file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're using the wrapper you don't need to install gradle

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
@Tianhao-Gu Tianhao-Gu merged commit 0225913 into main May 28, 2024
9 checks passed
@Tianhao-Gu Tianhao-Gu deleted the dev_add_delta_spark_packages branch May 28, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants