Restrict filename and format strings #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to a reasonable character set. This avoids characters that may cause issues in mac, linux, and windows
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #149 +/- ##
===========================================
+ Coverage 90.74% 90.83% +0.08%
===========================================
Files 14 14
Lines 2053 2073 +20
===========================================
+ Hits 1863 1883 +20
Misses 157 157
Partials 33 33 ☔ View full report in Codecov by Sentry. |
Xiangs18
reviewed
May 21, 2024
Comment on lines
+19
to
+20
| var fileCharsSet = createAllowedCharsSet(allowedFileChars) | ||
| var formatCharsSet = createAllowedCharsSet(allowedFormatChars) |
There was a problem hiding this comment.
Look like dicts to me. Are set concepts here similar to dictionary?
There was a problem hiding this comment.
There's no sets in Go, so dicts with empty values is how you implement a set
Xiangs18
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to a reasonable character set. This avoids characters that may cause issues in mac, linux, and windows