PTV-1911: Fix user search bugs re underscores + mongo errors #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed a bug where if a user name contained an underscore and the search term included the underscore followed by at least one letter the search wouldn't match * Fixed a bug where if the search terms were all illegal characters such that the search list was empty for a requested search a mongo error would be thrown
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #439 +/- ##
=============================================
- Coverage 93.37% 93.37% -0.01%
- Complexity 2144 2151 +7
=============================================
Files 126 126
Lines 7531 7558 +27
Branches 1178 1184 +6
=============================================
+ Hits 7032 7057 +25
- Misses 456 458 +2
Partials 43 43 |
| @@ -35,8 +39,8 @@ public class UserName extends Name { | |||
| } | |||
| } | |||
|
|
|||
| private static final String INVALID_CHARS_REGEX = "[^a-z\\d_]+"; | |||
| private final static Pattern INVALID_CHARS = Pattern.compile(INVALID_CHARS_REGEX); | |||
| private static final Pattern FORCE_ALPHA_FIRST_CHAR = Pattern.compile("^[^a-z]+"); | |||
There was a problem hiding this comment.
I hope 2pac never made a KBase account!
There was a problem hiding this comment.
I'm not sure how deep KBase has penetrated into the gangsta rap community
There was a problem hiding this comment.
Something to check with KBase outreach about.
| private static final String INVALID_CHARS_REGEX = "[^a-z\\d_]+"; | ||
| private final static Pattern INVALID_CHARS = Pattern.compile(INVALID_CHARS_REGEX); | ||
| private static final Pattern FORCE_ALPHA_FIRST_CHAR = Pattern.compile("^[^a-z]+"); | ||
| private final static Pattern INVALID_CHARS = Pattern.compile("[^a-z\\d_]+"); |
There was a problem hiding this comment.
can you use \\W+, since \w is equivalent to [a-z0-9_] in most regex implementations?
There was a problem hiding this comment.
That would work, but my personal preference is to use the more explicit form where you don't have to look up what W means
ialarmedalien
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #435