Publish shadow jar #437
Merged
Publish shadow jar #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #437 +/- ##
==========================================
Coverage 93.37% 93.37%
Complexity 2144 2144
==========================================
Files 126 126
Lines 7531 7531
Branches 1178 1178
==========================================
Hits 7032 7032
Misses 456 456
Partials 43 43 |
Xiangs18
reviewed
Apr 25, 2024
Comment on lines
-135
to
-142
| def fromURL = { url, name -> | ||
| File file = new File("$buildDir/download/${name}.jar") | ||
| file.parentFile.mkdirs() | ||
| if (!file.exists()) { | ||
| new URL(url).withInputStream { downloadStream -> | ||
| file.withOutputStream { fileOut -> | ||
| fileOut << downloadStream | ||
| } |
There was a problem hiding this comment.
This part is replaced by JitPack?
There was a problem hiding this comment.
It's just not needed any more, since all the jars can now be pulled from a maven repository rather than downloaded from some random location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.