Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mongo-retrywrites to config. #426

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

MrCreosote
Copy link
Member

The new client by default sets retry writes to true, which doesn't work for single servers.

This is painful to test locally so we'll need to test in CI.

The new client by default sets retry writes to true, which doesn't work
for single servers.

This is painful to test locally so we'll need to test in CI.
@MrCreosote MrCreosote requested a review from Xiangs18 February 15, 2024 23:02
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Merging #426 (93446ef) into gavin-inbox (060e222) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@              Coverage Diff               @@
##             gavin-inbox     #426   +/-   ##
==============================================
  Coverage          93.39%   93.39%           
- Complexity          2142     2143    +1     
==============================================
  Files                126      126           
  Lines               7520     7524    +4     
  Branches            1178     1178           
==============================================
+ Hits                7023     7027    +4     
  Misses               454      454           
  Partials              43       43           

@Xiangs18
Copy link
Collaborator

Copy link
Collaborator

@Xiangs18 Xiangs18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MrCreosote MrCreosote merged commit 4fb4758 into kbase:gavin-inbox Feb 15, 2024
3 checks passed
@MrCreosote MrCreosote mentioned this pull request Feb 15, 2024
@MrCreosote MrCreosote deleted the dev-retry_writes branch February 22, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants