Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs bug and urban-router import bug #22

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vareenrose
Copy link
Contributor

modify docs links and add typed props to the router component

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
urban-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 4:12am

Copy link

netlify bot commented May 21, 2024

Deploy Preview for lucky-tartufo-82564e ready!

Name Link
🔨 Latest commit aac1b8c
🔍 Latest deploy log https://app.netlify.com/sites/lucky-tartufo-82564e/deploys/664c1f041dc5fe00081e0e76
😎 Deploy Preview https://deploy-preview-22--lucky-tartufo-82564e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vareenrose vareenrose marked this pull request as draft May 21, 2024 04:16
@vareenrose vareenrose marked this pull request as ready for review May 21, 2024 04:23
@vareenrose
Copy link
Contributor Author

@katungi requesting review for this bug fix. Please note, there's sill an issue with regards to the lack of a main.tsx file in urban-router and urban-signals

@katungi
Copy link
Owner

katungi commented Jun 17, 2024

Hey @vareenrose , I am creating a group to better plan UrbanJs. I would like to add you to the group. Email me you number on [email protected] so I can add you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants